Prevent generation of 'year 0 is out of range' strings in IT #9918
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9916
This PR fixes some DataGen(StringGen) which generated out of range data in IT.
The regex:
can generated data start from 01-02-01, and keeps the invalid date as negative cases.
A simple breakdown:
(0{0,3}1-(0?[2-9]|[1-3][0-9]))
: 'valid' months in year 1, e. g. 001-2, 1-30(([1-9][0-9]{0,2}[01])-[0-3]?[0-9])
: years end with but not only 0, 1, all months.(([0-9]{0,3}[2-9])-[0-3]?[0-9])
: years end with 2-9, all months.Tested with large data locally without failed, and the coverage looks as excepted.