Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update cases for cast between integral and (date/time) #9957

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Update cases for cast between integral and (date/time) #9957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions integration_tests/src/main/python/cast_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,6 @@ def fun(spark):
short_gen,
int_gen,
long_gen_to_timestamp], ids=idfn)
@allow_non_gpu(*non_utc_allow)
def test_cast_integral_to_timestamp(gen, ansi_enabled):
if(is_before_spark_330() and ansi_enabled): # 330- does not support in ANSI mode
pytest.skip()
Expand Down Expand Up @@ -496,7 +495,6 @@ def test_cast_double_to_timestamp(ansi_enabled):
(INT_MIN - 1, IntegerType()),
], ids=idfn)
@pytest.mark.skipif(is_before_spark_330(), reason="Spark 330- does not ansi casting between numeric and timestamp")
@allow_non_gpu(*non_utc_allow)
def test_cast_timestamp_to_integral_ansi_overflow(invalid_and_type):
(invalid, to_type) = invalid_and_type
assert_gpu_and_cpu_error(
Expand All @@ -507,7 +505,6 @@ def test_cast_timestamp_to_integral_ansi_overflow(invalid_and_type):
error_message="overflow")

@pytest.mark.skipif(is_before_spark_330(), reason="Spark 330- does not ansi casting between numeric and timestamp")
@allow_non_gpu(*non_utc_allow)
def test_cast_timestamp_to_numeric_ansi_no_overflow():
data = [datetime.fromtimestamp(i) for i in range(BYTE_MIN, BYTE_MAX + 1)]
assert_gpu_and_cpu_are_equal_collect(
Expand All @@ -516,7 +513,6 @@ def test_cast_timestamp_to_numeric_ansi_no_overflow():
"cast(value as float)", "cast(value as double)"),
conf=ansi_enabled_conf)

@allow_non_gpu(*non_utc_allow)
def test_cast_timestamp_to_numeric_non_ansi():
assert_gpu_and_cpu_are_equal_collect(
lambda spark: unary_op_df(spark, timestamp_gen)
Expand Down Expand Up @@ -694,3 +690,8 @@ def test_cast_fallback_not_UTC(from_gen, to_type):
"Cast",
{"spark.sql.session.timeZone": "+08",
"spark.rapids.sql.castStringToTimestamp.enabled": "true"})

def test_cast_date_integral():
assert_gpu_and_cpu_are_equal_collect(
lambda spark: unary_op_df(spark, date_gen).selectExpr(
"cast(a as byte)", "cast(a as short)", "cast(a as int)", "cast(a as long)"))