save camera exposure as part of snapshot #448
Open
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeteHemery
reviewed
Apr 12, 2022
src/testbed.cu
Outdated
| @@ -2224,6 +2224,12 @@ void Testbed::save_snapshot(const std::string& filepath_string, bool include_opt | |||
| m_network_config["snapshot"]["nerf"]["rgb"]["measured_batch_size"] = m_nerf.training.counters_rgb.measured_batch_size; | |||
| m_network_config["snapshot"]["nerf"]["rgb"]["measured_batch_size_before_compaction"] = m_nerf.training.counters_rgb.measured_batch_size_before_compaction; | |||
| m_network_config["snapshot"]["nerf"]["dataset"] = m_nerf.training.dataset; | |||
|
|
|||
| nlohmann::json::binary_t cam_exposure_json; | |||
benjaclara
approved these changes
Apr 13, 2022
benjaclara
approved these changes
Apr 13, 2022
Tom94
force-pushed
the
master
branch
3 times, most recently
from
b04280e to
c1bd002
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the per-image camera exposures aren't saved as part of the snapshot and are lost if you exit the application and subsquently load from a snapshot