Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Interstitial ads - It shows up only once and isReady crashes on Android #125

Merged
merged 3 commits into from
May 20, 2024
Merged

Interstitial ads - It shows up only once and isReady crashes on Android #125

merged 3 commits into from
May 20, 2024

Conversation

gladiuscode
Copy link
Contributor

@gladiuscode gladiuscode commented Apr 23, 2024

This PR aims to fix the following issue.

We are using our patch at the moment, but it would be nice to have this PR merged for the next release, I believe this issue is quite critical, especially on Android where it crashes.

Thank you guys!

@mharrison-nzme
Copy link
Contributor

We will review this in the near future, thank you for your contribution

Copy link
Contributor

@jazdance jazdance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after going through tests, the change looks good.

@mharrison-nzme
Copy link
Contributor

This PR aims to fix the following issue.

We are using our patch at the moment, but it would be nice to have this PR merged for the next release, I believe this issue is quite critical, especially on Android where it crashes.

Thank you guys!

Thank you! I will publish a new npm version

@mharrison-nzme mharrison-nzme merged commit 8413784 into NZME:master May 20, 2024
@gladiuscode gladiuscode deleted the fix/interstials_is_ready_and_request branch May 23, 2024 23:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants