Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enabled app interstitials to re-appear after a number of user clicks on iOS #126

Merged

Conversation

traceymainzme
Copy link
Contributor

@traceymainzme traceymainzme commented May 1, 2024

Currently there's a bug where on iOS interstitial ads will only appear once, then not re-appear again after a certain number of user clicks (configured at 15).
According to Google's documentation, GADInterstitialAd is a one-time-use object. This means that once an interstitial ad is shown, it cannot be shown again. A best practice is to load another interstitial ad in the adDidDismissFullScreenContent: method on GADFullScreenContentDelegate so that the next interstitial ad starts loading as soon as the previous one is dismissed.
This tiny PR re-initialises another interstitial object in the aforementioned method so that requestAd functions correctly.
Tested locally on iOS device and emulator.

… so as to make it appear again in the same session
Copy link
Contributor

@jazdance jazdance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after going through tests, the change looks good.

@mharrison-nzme mharrison-nzme merged commit de56f16 into master May 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants