Version prefix matching #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puddly
force-pushed
the
puddly/version-prefix-matching
branch
from
27a293d to
cea218c
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version matching with EmberZNet currently fails due to a length mismatch between the firmware version and the GBL version. For example,
7.2.2.0 build 123is converted into7.2.2.0.123, but the GBL only includes7.2.2.0, which causes the matching to fail.I've replaced AwesomeVersion with a simpler solution that matches based on the shortest prefix, so the
.123part will be ignored.