Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix single/double quote not working within member list username CSS #3427

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

samerton
Copy link
Member

@samerton samerton commented Aug 2, 2023

If group username CSS includes a single quote ' or double quote " it will be escaped meaning the CSS will not work correctly within a member list

@samerton samerton added the bug label Aug 2, 2023
@samerton samerton added this to the 2.1.2 milestone Aug 2, 2023
@samerton samerton merged commit 7b7fa85 into develop Aug 21, 2023
@samerton samerton deleted the bugfix/member-list-html-entities branch August 21, 2023 16:06
samerton added a commit that referenced this pull request Sep 28, 2023
* Fix AuthMe enabled value (#3349)

* Add all missing languages to the Members module (#3350)

* Translated using translate.namelessmc.com

Co-authored-by: Knapp Bálint <favorit5503@gmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/hu/
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-forum/hu/
Translation: NamelessMC/Website - Core
Translation: NamelessMC/Website - Forum

* Translated using translate.namelessmc.com

Co-authored-by: Dominik Roman <dominikslk9@gmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/sk/
Translation: NamelessMC/Website - Core

* Translated using translate.namelessmc.com

Co-authored-by: Wgis <bywgis@gmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/ru/
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-discord-integration/ru/
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-forum/ru/
Translation: NamelessMC/Website - Core
Translation: NamelessMC/Website - Discord Integration
Translation: NamelessMC/Website - Forum

* Make sure Minecraft Integration is enabled (#3356)

* Add Russian translation (#3352)

Contributed by @Wgis in a github comment: #3350 (comment)

Co-authored-by: Ilya Finogenov <20740613+wgis@users.noreply.github.com>

* Translated using translate.namelessmc.com

Co-authored-by: NamelessMC Translations <robin+weblate@rkslot.nl>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/nl/
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-members-module/nl/
Translation: NamelessMC/Website - Core
Translation: NamelessMC/Website - Members module

* Translated using translate.namelessmc.com

Co-authored-by: Dominik Roman <dominikslk9@gmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-members-module/sk/
Translation: NamelessMC/Website - Members module

* Translated using translate.namelessmc.com

Co-authored-by: enno123 <admin@enno123.de>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-members-module/de/
Translation: NamelessMC/Website - Members module

* Translated using translate.namelessmc.com

Co-authored-by: Marcos <marckos03br@gmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/es/
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-members-module/es/
Translation: NamelessMC/Website - Core
Translation: NamelessMC/Website - Members module

* Translated using translate.namelessmc.com

Co-authored-by: Fjuro <ifjuro@proton.me>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-members-module/cs/
Translation: NamelessMC/Website - Members module

* Include .htaccess file in release zip (#3362)

* Fix missing cache settings (#3361)

* Fix user group isssue (#3365)

Closes #3363

* Fix forum title/description encoding on edit (#3359)

* Remove unable to update groups catch (#3360)

* Translated using translate.namelessmc.com

Co-authored-by: David Morales <davidmolv16@gmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-members-module/es_419/
Translation: NamelessMC/Website - Members module

* Remove placeholder from singular message (#3369)

* Fix not being able to see Members page in Navigation settings (#3372)

* Translated using translate.namelessmc.com

Co-authored-by: enno123 <admin@enno123.de>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/de/
Translation: NamelessMC/Website - Core

* Translated using translate.namelessmc.com

Co-authored-by: Fjuro <ifjuro@proton.me>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/cs/
Translation: NamelessMC/Website - Core

* Translated using translate.namelessmc.com

Co-authored-by: Edouard DUCHESNES <edouard@duchesnes.fr>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/fr/
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-discord-integration/fr/
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-members-module/fr/
Translation: NamelessMC/Website - Core
Translation: NamelessMC/Website - Discord Integration
Translation: NamelessMC/Website - Members module

* Translated using translate.namelessmc.com

Co-authored-by: Marcos <marckos03br@gmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/es/
Translation: NamelessMC/Website - Core

* Translated using translate.namelessmc.com

Co-authored-by: Mesutcan Yavuz <mesutcan.yavuz@hotmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/cookie-consent/tr/
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/tr/
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-discord-integration/tr/
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-forum/tr/
Translation: NamelessMC/Website - Cookie Consent
Translation: NamelessMC/Website - Core
Translation: NamelessMC/Website - Discord Integration
Translation: NamelessMC/Website - Forum

* Translated using translate.namelessmc.com

Co-authored-by: Mesutcan Yavuz <mesutcan.yavuz@hotmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/tr/
Translation: NamelessMC/Website - Core

* Translated using translate.namelessmc.com

Co-authored-by: Maiu <maiuxd77@gmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/nb_NO/
Translation: NamelessMC/Website - Core

* Translated using translate.namelessmc.com

Co-authored-by: Dominik Roman <dominikslk9@gmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/sk/
Translation: NamelessMC/Website - Core

* Translated using translate.namelessmc.com

Co-authored-by: andreas phillip søndergaard andersen <andreas.andersen1410@gmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-forum/da/
Translation: NamelessMC/Website - Forum

* Fix multi query (#3383)

* Add id to default server

* Fix multiquery

* Fix icon not being properly shown (#3377)

* Fix ghost player on status page (#3351)

Co-authored-by: Tadhg Boyle <tadhgsmboyle@gmail.com>

* Translated using translate.namelessmc.com

Co-authored-by: andreas phillip søndergaard andersen <andreas.andersen1410@gmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-forum/da/
Translation: NamelessMC/Website - Forum

* Translated using translate.namelessmc.com

Co-authored-by: NamelessMC Translations <robin+weblate@rkslot.nl>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/nl/
Translation: NamelessMC/Website - Core

* Translated using translate.namelessmc.com

Co-authored-by: Petr Kubinec <petrkubinec9@gmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/en_US/
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-forum/en_US/
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-members-module/en_US/
Translation: NamelessMC/Website - Core
Translation: NamelessMC/Website - Forum
Translation: NamelessMC/Website - Members module

* Translated using translate.namelessmc.com

Co-authored-by: untuned <untuned@teamhydra.dev>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/en_US/
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-members-module/en_US/
Translation: NamelessMC/Website - Core
Translation: NamelessMC/Website - Members module

* Translated using translate.namelessmc.com

Co-authored-by: Mert <mert2018cinar@gmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/tr/
Translation: NamelessMC/Website - Core

* Translated using translate.namelessmc.com

Co-authored-by: Justman10000 <justmegaliga10000@gmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/de/
Translation: NamelessMC/Website - Core

* Call `compileQueries` only when needed (#3386)

* Translated using translate.namelessmc.com

Co-authored-by: Justman10000 <justmegaliga10000@gmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/de/
Translation: NamelessMC/Website - Core

* Remove Discord discriminator requirement (#3374)

* Fix outdated event

* Fix oauth linking for forced integrations (#3395)

* Require module autoload file before module init (#3397)

* Require module autoload file before module init

* Change module loading to require once

* Prepare 1.1.1 release (#3399)

* Small misc improvements (#3389)

* Support custom migration tables

* Allow specifying custom migrations directory

* PHP 7.4 fix

* Consistent parameters and add rollback function

* Update Phinx and fix migrations

* Tidy strtolower

* Phinx feature flags

* Make makeWhere function in DB class public

* Add new buildAssetPath function to URL class

---------

Co-authored-by: Robin Slot <robin+github@rkslot.nl>

* Translated using translate.namelessmc.com

Co-authored-by: Justman10000 <justmegaliga10000@gmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/de/
Translation: NamelessMC/Website - Core

* Rework user group cache issue (#3398)

* Add `PHP_SAPI` checks on scripts (#3403)

* Readd deleted term + fix discord oauth link success message (#3406)

* Revert deleted language term

Removed in a0e9ffb

@tadhgboyle

* Add success message for linking discord

* Translated using translate.namelessmc.com

Co-authored-by: enno123 <admin@enno123.de>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/de/
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-forum/de/
Translation: NamelessMC/Website - Core
Translation: NamelessMC/Website - Forum

* Fix typo in en_US.json (#3412)

* Fix auto verify oauth email (#3413)

* Translated using translate.namelessmc.com

Co-authored-by: Fjuro <ifjuro@proton.me>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/cs/
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-forum/cs/
Translation: NamelessMC/Website - Core
Translation: NamelessMC/Website - Forum

* Translated using translate.namelessmc.com

Co-authored-by: Andiv <div2005.kk@gmail.com>
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/ru/
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/nameless/uk/
Translate-URL: https://translate.namelessmc.com/projects/namelessmc/website-forum/ru/
Translation: NamelessMC/Website - Core
Translation: NamelessMC/Website - Forum

* Rewrite release script to fix checksums in upgrade package (#3414)

* Fix forum index showing topics without view other topics permission

* Ignore group sync request instead of returning error (#3433)

* Ignore group sync request instead of returning error

* Fix condition

* Remove return

* Limit logs & Support group sync from modules (#3426)

* Limit logs

* Support group sync from modules

* Ignore adding group if its invalid (#3436)

* Ignore adding group if its invalid (#3436)

* Fix phpdoc build, pin version (#3438)

* Fix single/double quote not working within member list username CSS (#3427)

* Prepare 2.1.2 release

---------

Co-authored-by: DominikSLK <74055080+DominikSLK@users.noreply.github.com>
Co-authored-by: PadowYT2 <me@padow.ru>
Co-authored-by: Knapp Bálint <favorit5503@gmail.com>
Co-authored-by: Dominik Roman <dominikslk9@gmail.com>
Co-authored-by: Wgis <bywgis@gmail.com>
Co-authored-by: Partydragen <adrian_kili@outlook.com>
Co-authored-by: Robin <robin+git@rkslot.nl>
Co-authored-by: Ilya Finogenov <20740613+wgis@users.noreply.github.com>
Co-authored-by: NamelessMC Translations <robin+weblate@rkslot.nl>
Co-authored-by: enno123 <admin@enno123.de>
Co-authored-by: Marcos <marckos03br@gmail.com>
Co-authored-by: Fjuro <ifjuro@proton.me>
Co-authored-by: David Morales <davidmolv16@gmail.com>
Co-authored-by: Tadhg Boyle <tadhgsmboyle@gmail.com>
Co-authored-by: Edouard DUCHESNES <edouard@duchesnes.fr>
Co-authored-by: Mesutcan Yavuz <mesutcan.yavuz@hotmail.com>
Co-authored-by: Maiu <maiuxd77@gmail.com>
Co-authored-by: andreas phillip søndergaard andersen <andreas.andersen1410@gmail.com>
Co-authored-by: Supercrafter100 <58982133+supercrafter100@users.noreply.github.com>
Co-authored-by: Petr Kubinec <petrkubinec9@gmail.com>
Co-authored-by: untuned <untuned@teamhydra.dev>
Co-authored-by: Mert <mert2018cinar@gmail.com>
Co-authored-by: Justman10000 <justmegaliga10000@gmail.com>
Co-authored-by: Robin Slot <robin+github@rkslot.nl>
Co-authored-by: Andiv <div2005.kk@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants