Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(xero): Fix xero endpoints & tweak precommit script to generate tests #82

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

khaliqgant
Copy link
Member

Describe your changes

  • Fix endpoints
  • Update precommit script to only operate on changed files

Issue ticket number and link

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • External API requests have retries
  • Pagination is used where appropriate
  • The built in nango.paginate call is used instead of a while (true) loop
  • Third party requests are NOT parallelized (this can cause issues with rate limits)
  • If a sync requires metadata the nango.yaml has auto_start: false
  • If the sync is a full sync then track_deletes: true is set

@khaliqgant khaliqgant enabled auto-merge (squash) October 30, 2024 09:17
@khaliqgant khaliqgant merged commit 676a094 into main Oct 30, 2024
5 checks passed
@khaliqgant khaliqgant deleted the fix-xero-endpoints branch October 30, 2024 09:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant