fix: node routingId/deploymentId is not unique

Ex: in case of error, a new node with same routingId/deploymentId will be created in case of runner idled because of inactivity, a new node with same routingId/deploymentId will be created
NangoHQ · Dec 5, 2024 · 0a2ded7 · 0a2ded7
1 parent 9831ce4
commit 0a2ded7
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 26 deletions.
diff --git a/packages/fleet/lib/db/migrations/20241102115903_initial_fleet_models.ts b/packages/fleet/lib/db/migrations/20241102115903_initial_fleet_models.ts
@@ -43,10 +43,6 @@ export async function up(knex: Knex): Promise<void> {
                 last_state_transition_at timestamp with time zone NOT NULL DEFAULT CURRENT_TIMESTAMP
             );
         `);
-        await trx.raw(`
-            CREATE UNIQUE INDEX idx_${NODES_TABLE}_routingId_deploymentId
-                ON ${NODES_TABLE}(routing_id, deployment_id);
-        `);
         await trx.raw(`
             CREATE INDEX idx_${NODES_TABLE}_routingId_state
                 ON ${NODES_TABLE}(routing_id, state)

diff --git a/packages/fleet/lib/models/nodes.integration.test.ts b/packages/fleet/lib/models/nodes.integration.test.ts
@@ -50,28 +50,6 @@ describe('Nodes', () => {
             lastStateTransitionAt: expect.any(Date)
         });
     });
-    it('should fail to create a node with the same routingId and deploymentId', async () => {
-        const routingId = 'my-routing-id';
-        await nodes.create(db, {
-            routingId,
-            deploymentId: activeDeployment.id,
-            url: 'http://localhost:3000',
-            image: 'nangohq/my-image:latest',
-            cpuMilli: 500,
-            memoryMb: 1024,
-            storageMb: 512
-        });
-        const result = await nodes.create(db, {
-            routingId,
-            deploymentId: activeDeployment.id,
-            url: 'http://localhost:3000',
-            image: 'nangohq/my-image:latest',
-            cpuMilli: 500,
-            memoryMb: 1024,
-            storageMb: 512
-        });
-        expect(result.isErr()).toBe(true);
-    });
     it('should transition between valid states and error when transitioning between invalid states', async () => {
         for (const from of nodeStates) {
             for (const to of nodeStates) {