Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Dry run: too many objects logged + all at the end #1022

Closed
bastienbeurier opened this issue Sep 18, 2023 · 0 comments · Fixed by #1187
Closed

Dry run: too many objects logged + all at the end #1022

bastienbeurier opened this issue Sep 18, 2023 · 0 comments · Fixed by #1187
Assignees
@khaliqgant
Labels
enhancement New feature or request

Comments

@bastienbeurier
Copy link
Member

bastienbeurier commented Sep 18, 2023 •
edited
Loading

When running dry run and a large number of objects is returned, it becomes hard to see the initial command, log messages, etc.

To improve the DX here, we could log only x objects by default, state how many are available, and 'press enter' to log x more.

Also, it'd be great if they are all logged at the end, to not have the batchSave logs in between nango.log calls.
@bastienbeurier bastienbeurier added the enhancement New feature or request label Sep 18, 2023
@bastienbeurier bastienbeurier moved this to Later in Nango Roadmap Sep 18, 2023
This was referenced Sep 18, 2023
Closed
Closed
@bastienbeurier bastienbeurier changed the title Dry run: too many objects logged Dry run: too many objects logged + all at the end Sep 18, 2023
@bastienbeurier bastienbeurier moved this from Later to Soon in Nango Roadmap Oct 19, 2023
@khaliqgant khaliqgant moved this from Soon to Now in Nango Roadmap Oct 26, 2023
khaliqgant added a commit that referenced this issue Oct 26, 2023
@khaliqgant
[gh-#1022] display log messages at the end and prompt to show more
1ae50d9
khaliqgant added a commit that referenced this issue Oct 26, 2023
@khaliqgant
[gh-#1022] [gh-#1020] allow metadata to be stubbed in a dryRun
b6b8604
@khaliqgant khaliqgant mentioned this issue Oct 26, 2023
Merged
khaliqgant added a commit that referenced this issue Oct 26, 2023
@khaliqgant
[Github #1022] dryrun log messages (#1187)
172dd3d 
* [gh-#1022] display log messages at the end and prompt to show more

* [gh-#1022] [gh-#1020] allow metadata to be stubbed in a dryRun
@github-project-automation github-project-automation bot moved this from Now to Done in Nango Roadmap Oct 26, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@khaliqgant khaliqgant

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Github #1022] dryrun log messages NangoHQ/nango
2 participants
@khaliqgant @bastienbeurier