Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Track deletes improvements & investigation #1094

Closed
khaliqgant opened this issue Oct 11, 2023 · 0 comments · Fixed by #1095
Closed

Track deletes improvements & investigation #1094

khaliqgant opened this issue Oct 11, 2023 · 0 comments · Fixed by #1095
Assignees
Labels
enhancement New feature or request

Comments

@khaliqgant
Copy link
Member

khaliqgant commented Oct 11, 2023

another thing I noticed is that when I make a change to a Notion page, this page has last_action: "ADDED" when I pull it in with getRecords. Should it not be UPDATED? I checked and it's the same record ID

@khaliqgant khaliqgant self-assigned this Oct 11, 2023
khaliqgant added a commit that referenced this issue Oct 11, 2023
@khaliqgant khaliqgant moved this to Now in Nango Roadmap Oct 11, 2023
khaliqgant added a commit that referenced this issue Oct 12, 2023
* [gh-#1094] maintain the created_at timestamp so we know what was updated and what was added

* [gh-#1094] on connection delete remove the sync data records deletes
@github-project-automation github-project-automation bot moved this from Now to Done in Nango Roadmap Oct 12, 2023
khaliqgant added a commit that referenced this issue Oct 12, 2023
khaliqgant added a commit that referenced this issue Oct 12, 2023
khaliqgant added a commit that referenced this issue Oct 12, 2023
* [gh-#1094] make call more specific for updatedKeys only

* [gh-#1094] supporting test

* [gh-#1094] remove log
@bastienbeurier bastienbeurier added the enhancement New feature or request label Oct 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants