Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Proxy option to log headers + obfuscate auth-releated headers #1201

Closed
bastienbeurier opened this issue Oct 30, 2023 · 0 comments · Fixed by #1204 or #1249
Closed

Proxy option to log headers + obfuscate auth-releated headers #1201

bastienbeurier opened this issue Oct 30, 2023 · 0 comments · Fixed by #1204 or #1249
Assignees
@khaliqgant
Labels
enhancement New feature or request

Comments

@bastienbeurier
Copy link
Member

bastienbeurier commented Oct 30, 2023 •
edited
Loading

I think proxy header logging should be enabled by default (for now) to help with debugging.

IMO the logic to detect auth-related headers can start simple (e.g. searching header names for 'auth', 'token', 'key', etc). We should still show the header name and replace the header content with 'xxx'.
@bastienbeurier bastienbeurier added the enhancement New feature or request label Oct 30, 2023
khaliqgant added a commit that referenced this issue Oct 31, 2023
@khaliqgant
[gh-#1201] don't expose authorization in the header
f61c68f
@khaliqgant khaliqgant mentioned this issue Oct 31, 2023
Merged
khaliqgant added a commit that referenced this issue Oct 31, 2023
@khaliqgant
[gh-#1201] more specific query
f9804ab
khaliqgant added a commit that referenced this issue Oct 31, 2023
@khaliqgant
[gh-#1201] don't expose authorization in the header (#1204)
c6b98d7 
* [gh-#1201] don't expose authorization in the header

* [gh-#1201] more specific query
@github-project-automation github-project-automation bot moved this from Now to Done in Nango Roadmap Oct 31, 2023
@khaliqgant khaliqgant reopened this Nov 8, 2023
khaliqgant added a commit that referenced this issue Nov 8, 2023
@khaliqgant
[gh-#1201] strip away unauth token when included
aeb19c0
@khaliqgant khaliqgant mentioned this issue Nov 8, 2023
Merged
khaliqgant added a commit that referenced this issue Nov 8, 2023
@khaliqgant
[gh-#1201] strip away unauth token when included (#1249)
355899a
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@khaliqgant khaliqgant

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@khaliqgant @bastienbeurier