Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding in Pagerduty support #112

Merged
merged 3 commits into from
Oct 5, 2020
Merged

Adding in Pagerduty support #112

merged 3 commits into from
Oct 5, 2020

Conversation

nicksteenstra
Copy link
Contributor

Proposed changes

Adding in new config to support Pagerduty.

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [X ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ X] I have read the CONTRIBUTING guide
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@Frenchcooc Frenchcooc linked an issue Oct 2, 2020 that may be closed by this pull request
Copy link
Contributor

@Frenchcooc Frenchcooc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the authorization header? Or can you confirm you've tested the configuration first?

Co-authored-by: Corentin <corentin.brossault@gmail.com>
Copy link
Contributor

@Frenchcooc Frenchcooc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@Frenchcooc Frenchcooc merged commit 0b4baff into NangoHQ:master Oct 5, 2020
nango-repository-pusher bot pushed a commit that referenced this pull request Nov 18, 2024
…sed on changes in NangoHQ/integration-templates@290a958 by Khaliq. Commit message: fix(outlook): fix sender property (#112)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagerduty API integration request
2 participants