[Github #1192] slack alerts #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unt for failing connections
bastienbeurier
approved these changes
Oct 31, 2023
bodinsamuel
added a commit
that referenced
this pull request
May 31, 2024
## Changes Directly related to implem: - UI: bad loading state when opening the operation drawer - UI: search in operation's logs was not working after latest PR - ES: if we don't `refresh=true` index after inserting operation it can sometimes be missing from the index when we reach jobs making it impossible to update state, unfortunately that will slow down insert of operation not sure by how much Other related changes: - `syncRunService` clarify what we expect in terms of logging options (with types) when dryRun or not We either `writeToDB` and needs everything related to logs, or nothing. - `syncRunService` now takes a mandatory logCtx (if writeToDb=true) In `activities.ts` we create an operation for `sync run`, but when we entered this service (on the same machine) we had to get the operation back with the activityLogId which was definitely unnecessary and slowing down everything. - `triggerAction()` never takes an optional activityLogId and `writeLogs` at all It helps simplify the code and ensure we have the data in activities.ts. I could not find a place where we don't pass an activityLogId and use this writeLogs=false. I saw it was introduced in an old [PR](#1202) let me know @khaliqgant
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1192
Resolves #1151
Deployment To Dos
flow-result-notifier-actionto the Nango admin account on both staging and prodadmin-slackconnection