Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(sync): verifyOwnership not awaited #1952

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix(sync): verifyOwnership not awaited #1952

merged 1 commit into from
Apr 4, 2024

Conversation

bodinsamuel
Copy link
Collaborator

Describe your changes

Fixes NAN-690

  • Correctly await verifyOwnership
  • Add missing return after response code
  • Reuse activityLogId

@bodinsamuel bodinsamuel self-assigned this Apr 4, 2024
@linear Linear
Copy link

linear bot commented Apr 4, 2024

NAN-690 syncCommand verifyOwnership is not awaited

@bodinsamuel bodinsamuel merged commit 05ab9cc into master Apr 4, 2024
19 checks passed
@bodinsamuel bodinsamuel deleted the fix/syncCommand-bug branch April 4, 2024 10:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@khaliqgant khaliqgant khaliqgant approved these changes

@TBonnin TBonnin Awaiting requested review from TBonnin

Assignees

@bodinsamuel bodinsamuel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bodinsamuel @khaliqgant