fix(action): debug empty response #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodinsamuel
requested review from
TBonnin and
khaliqgant
and removed request for
TBonnin
bodinsamuel
commented
May 15, 2024
| @@ -430,6 +430,7 @@ class SyncController { | |||
| await logCtx.failed(); | |||
| span.finish(); | |||
|
|
|||
| next(actionResponse.error); | |||
There was a problem hiding this comment.
maybe I'm crazy but this if never worked?
There was a problem hiding this comment.
that would be a good job for a compiler/linter to tell you an handler doesn't call next or send ;)
TBonnin
approved these changes
May 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
There is an ongoing issue where a customer receive a 500 when running an action but without any log showing
res.sendwas used to output the body but could fail if the body was a number, express would interpret that as a wrong status code