feat(scripts): [nan-973] slack integration for each environment #2168
Conversation
| @@ -114,7 +114,7 @@ export function checkEnvVars(optionalHostport?: string) { | |||
|
|
|||
| let pkgVersion: string | undefined = undefined; | |||
| export function getPkgVersion(debug = false) { | |||
| if (pkgVersion) { | |||
| if (pkgVersion && !debug) { | |||
There was a problem hiding this comment.
Something that is very important to my workflow is to know where the CLI is running from. Because the pkgVersion is fetched in the getUserAgent() method on startup and cached the path wasn't being outputted. So with this the cache is skipped so the full debug information can be outputted if debug is set.
| @@ -372,7 +372,7 @@ export const EnvironmentSettings: React.FC = () => { | |||
| }; | |||
|
|
|||
| const connectSlack = async () => { | |||
| const connectionId = `account-${accountUUID}`; | |||
There was a problem hiding this comment.
is this retroactive somehow?
There was a problem hiding this comment.
No. Going to manually update the prod connections. Only 20 or so
There was a problem hiding this comment.
maybe self hosted / enterprise are using this feature? if so could be done with a transaction
There was a problem hiding this comment.
Enterprise definitely isn’t using the feature and since this is only for syncs / actions can almost guarantee that self hosted isn’t either
Describe your changes
Allow a slack integration to be created at each env level. CLI fixes
Issue ticket number and link
NAN-973
Checklist before requesting a review (skip if just adding/editing APIs & templates)