Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add typing to node client #226

Merged
merged 3 commits into from
May 12, 2021
Merged

Add typing to node client #226

merged 3 commits into from
May 12, 2021

Conversation

markmichon
Copy link
Contributor

Proposed changes

Updates the node client's tsconfig to support issue #220, adds strict mode, and updates the package file with the correct url.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@markmichon
Copy link
Contributor Author

@Nightbr Does this look like it will resolve your type issue? Decided to go the declaration approach for now rather than mix it with separate compilation targets for es modules.

@Nightbr
Copy link
Contributor

Nightbr commented Apr 29, 2021

Yep seems working on my side ;) GJ!
image

Perhaps could be great to update the doc because now you have to import Pizzly like this:

import { Pizzly } from 'pizzly-node';

VS import Pizzly from 'pizzly-node'; before

@markmichon
Copy link
Contributor Author

I'd rather avoid a breaking change like that if possible. I'll try to find time to look into the multiple outputs approach from your initial issue and see if it helps avoid that problem.

@Nightbr
Copy link
Contributor

Nightbr commented May 11, 2021

I think both works (look at the javascript client https://github.com/Bearer/Pizzly/tree/master/src/clients/javascript) but my strict config in NestJs ask me to import like this import { Pizzly } from 'pizzly-node';
to be verified but seems ok on the javascript client.

@markmichon markmichon merged commit 1e6f97c into master May 12, 2021
@markmichon markmichon deleted the add-typing branch May 12, 2021 14:50
@markmichon
Copy link
Contributor Author

Ran a quick proof of concept and it looks like you're right. This is live in 0.2.1. Thanks!

nango-repository-pusher bot pushed a commit that referenced this pull request Feb 21, 2025
…sed on changes in NangoHQ/integration-templates@5f29fa5 by Victor Lang'at. Commit message: feat(netsuite-tba): add netsuite actions (#226)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants