Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(ui): allow to dismiss slack banner #2866

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

bodinsamuel
Copy link
Collaborator

Describe your changes

Fixes https://linear.app/nango/issue/NAN-1811/make-slack-banner-dismissable-per-environment

  • Allow dismissing slack banner
    It's done on the frontend side only, we can improve that later by storing the flag somewhere in the backend but we don't have such a feature and it's a massive job for not much value.

@bodinsamuel bodinsamuel self-assigned this Oct 21, 2024
Copy link

linear bot commented Oct 21, 2024

@bodinsamuel bodinsamuel enabled auto-merge (squash) October 22, 2024 08:26
@bodinsamuel bodinsamuel merged commit 6c7cfde into master Oct 22, 2024
21 checks passed
@bodinsamuel bodinsamuel deleted the sam/fix/ui-slack-banner-dismiss branch October 22, 2024 08:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants