feat(notion-scim): Support notion SCIM #2880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodinsamuel
reviewed
Oct 24, 2024
| apiKey: | ||
| type: string | ||
| title: API Key | ||
| description: The API key for your Notion account |
There was a problem hiding this comment.
It's missing validation and verification, otherwise somebody will need to painfully backfill those 😬
There was a problem hiding this comment.
Yeah. Missing both because we can’t access a Notion enterprise account so I dont know what either look like
bodinsamuel
approved these changes
Oct 24, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add Notion scim as a specific provider
Issue ticket number and link
Checklist before requesting a review (skip if just adding/editing APIs & templates)