fix(connections): add FK to end users #2883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodinsamuel
commented
Oct 24, 2024
| @@ -7,6 +7,7 @@ export type ConnectionConfig = Record<string, any>; | |||
| export interface BaseConnection extends TimestampsAndDeleted { | |||
| id?: number; | |||
| config_id?: number; | |||
| end_user_id?: number; | |||
There was a problem hiding this comment.
undefined on purpose until I fix the implementation
TBonnin
approved these changes
Oct 24, 2024
| */ | ||
| exports.up = async function (knex) { | ||
| await knex.raw(`ALTER TABLE "_nango_connections" ADD COLUMN "end_user_id" int4`); | ||
| await knex.raw(`ALTER TABLE "_nango_connections" ADD FOREIGN KEY ("end_user_id") REFERENCES "end_users" ("id") ON DELETE SET NULL`); |
There was a problem hiding this comment.
can we not do that in one single query:
ALTER TABLE "_nango_connections"
ADD COLUMN "end_user_id" int4,
ADD FOREIGN KEY ("end_user_id") REFERENCES "end_users" ("id") ON DELETE SET NULL;
There was a problem hiding this comment.
I'm sure I could, not sure what would be the benefit, it's 2 different queries
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Contributes to https://linear.app/nango/issue/NAN-1944/connect-end-users-to-connections
Add Foreign Key from connections to end_users
Implementation will come after
Add Foreign Key from oauth_session to connect_session to be able to get back the session on the callback
Implementation will come after