fix(pagination): [nan-1958] per page offset pagination #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaliqgant
changed the title
7 tasks
TBonnin
approved these changes
Oct 25, 2024
khaliqgant
deleted the
khaliq/nan-1958-pagination-doesnt-support-per-page-pagination
branch
khaliqgant
added a commit
to NangoHQ/integration-templates
that referenced
this pull request
Oct 25, 2024
## Describe your changes Add in datadata user operations Blocked by NangoHQ/nango#2890 ## Issue ticket number and link ## Checklist before requesting a review (skip if just adding/editing APIs & templates) - [ ] I added tests, otherwise the reason is: - [ ] External API requests have `retries` - [ ] Pagination is used where appropriate - [ ] The built in `nango.paginate` call is used instead of a `while (true)` loop - [ ] Third party requests are NOT parallelized (this can cause issues with rate limits) - [ ] If a sync requires metadata the `nango.yaml` has `auto_start: false` - [ ] If the sync is a `full` sync then `track_deletes: true` is set
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Offset right now only adds the response data length but many APIs just need the page to be incremented by one. As seen in NangoHQ/integration-templates#72
Issue ticket number and link
NAN-1958
Checklist before requesting a review (skip if just adding/editing APIs & templates)