fix(connect): document connect ui, add apiURL param #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
approved these changes
Oct 28, 2024
| @@ -100,7 +136,7 @@ const result = nango.auth('<INTEGRATION-ID>', '<CONNECTION-ID>', { | |||
| The integration ID that you can find in the integration settings on the Nango UI. | |||
| </ResponseField> | |||
|
|
|||
| <ResponseField name="connectionId" type="string" required> | |||
| <ResponseField name="connectionId" type="string"> | |||
There was a problem hiding this comment.
I think we need to also update the docs-v2/spec.yaml file to make the connection_id field not required for the POST /connection endpoint
| ```js | ||
| const result = await nango.auth('<INTEGRATION-ID>', '<CONNECTION-ID>'); | ||
| ``` | ||
|
|
There was a problem hiding this comment.
do we even document this option or not?
There was a problem hiding this comment.
For legacy reason, I think it's somewhat required
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Contributes https://linear.app/nango/issue/NAN-1923/make-nango-connect-the-only-way-to-create-connection-in-nango-ui
The old doc has been moved to advanced.