Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(proxy): fix TikTok Ads access_token header for proxy requests #2933

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

hassan254-prog
Copy link
Contributor

@hassan254-prog hassan254-prog commented Oct 31, 2024

Describe your changes

  • Dynamically build authentication in headers for TikTok Ads.

Issue ticket number and link

EXT-167

@hassan254-prog hassan254-prog marked this pull request as draft November 4, 2024 15:56
@hassan254-prog hassan254-prog force-pushed the wari/dynamically-build-auth-headers branch from 8694ff8 to 5b64192 Compare November 4, 2024 17:38
@hassan254-prog hassan254-prog reopened this Nov 4, 2024
@hassan254-prog
Copy link
Contributor Author

I will focus on fixing headers for TikTok for this specific task and open another PR when we may have a new JWT provider with dynamic headers.

@hassan254-prog hassan254-prog marked this pull request as ready for review November 4, 2024 17:52
@hassan254-prog hassan254-prog enabled auto-merge (squash) November 6, 2024 05:46
@bodinsamuel
Copy link
Collaborator

@hassan254-prog the PR seems to be very different now, is the title still correct or not ready to review?

@hassan254-prog hassan254-prog changed the title feat(proxy): dynamically build authentication in headers feat(proxy): fix TikTok Ads access_token header for proxy requests Nov 7, 2024
@hassan254-prog
Copy link
Contributor Author

hassan254-prog commented Nov 7, 2024

@hassan254-prog the PR seems to be very different now, is the title still correct or not ready to review?

Yes, I’ve renamed the title to reflect the new changes, sorry about that.

@hassan254-prog hassan254-prog enabled auto-merge (squash) November 7, 2024 09:55
@hassan254-prog hassan254-prog merged commit c9bf96d into master Nov 7, 2024
20 checks passed
@hassan254-prog hassan254-prog deleted the wari/dynamically-build-auth-headers branch November 7, 2024 10:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants