fix(jobs): use new docker image #2945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
reviewed
Nov 5, 2024
There was a problem hiding this comment.
I don't remember why jobs is not yet using the unified image. Do you remember? @bodinsamuel
| @@ -91,12 +91,15 @@ RUN true \ | |||
| && apt-get purge -y --auto-remove -o APT::AutoRemove::RecommendsImportant=false | |||
|
|
|||
| # Do not use root to run the app | |||
| USER node | |||
| # BUT it does not work with secret mount (could not find a solution yet) | |||
There was a problem hiding this comment.
when do we need secret mount?
There was a problem hiding this comment.
To load Google credentials for bigquery
There was a problem hiding this comment.
do we need to find a solution before merging this change?
There was a problem hiding this comment.
nope, just running as root is good, <i just left the comment to be sure the next person is not trying to put an user back
No big reasons, it was just a matter of taking the time |
TBonnin
approved these changes
Nov 6, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Already deployed in staging, nb: requires manual change before deployment on prod