Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(jobs): Pass PROVIDERS_URL and PROVIDERS_RELOAD_INTERVAL to runners #2983

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

nalanj
Copy link
Contributor

@nalanj nalanj commented Nov 13, 2024

Describe your changes

Sets up needed ENV vars for providers reloading to render runner and local runner.

@TBonnin No env vars were set in RemoteRunner, but it wasn't completely clear to me how RemoteRunner works at this point. I may need help figuring out how it works.

Issue ticket number and link

See https://linear.app/nango/issue/NAN-2105/dynamically-reload-providersyaml

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • I added observability, otherwise the reason is:
  • I added analytics, otherwise the reason is:

Copy link

linear bot commented Nov 13, 2024

@TBonnin
Copy link
Collaborator

TBonnin commented Nov 13, 2024

Remote runner is for Enterprise customer who are running Nango in their own infrastructure. In this case we don't control where the runner(s) are.
We should document this env var in case Enterprise customers want to also use the dynamic url (@khaliqgant do we have an Enterprise setup guide somewhere?) but we should also make sure that the providers data is loaded from binary if this env var is not specified. In a single tenant enterprise setup, dynamic loading of providers isn't bringing much value anyway

@nalanj nalanj marked this pull request as ready for review November 13, 2024 18:38
@nalanj nalanj self-assigned this Nov 13, 2024
@nalanj nalanj requested a review from a team November 13, 2024 18:38
@nalanj nalanj added this pull request to the merge queue Nov 14, 2024
@TBonnin TBonnin removed this pull request from the merge queue due to the queue being cleared Nov 14, 2024
@nalanj nalanj merged commit 66f936b into master Nov 14, 2024
20 checks passed
@nalanj nalanj deleted the alan/nan-2105/jobs-providers-url-env branch November 14, 2024 13:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants