fix(quickbooks): prompt user for a realmId connection config parameter #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hassan254-prog
force-pushed
the
kelvinwari/ext-244-quickbooks-realmid-isnt-always-provided-in-the-authorization
branch
from
c69d0c5 to
09f7664
Compare
bodinsamuel
approved these changes
Nov 18, 2024
|
|
||
| quickbooks-sandbox: | ||
| alias: quickbooks | ||
| display_name: Quickbooks (sandbox) | ||
| proxy: | ||
| connection_config: | ||
| realmId: ${connectionConfig.realmId} |
There was a problem hiding this comment.
I think it's a follow-up question from the aws PR I didn't get, How are we supposed to use it if it's not in a URL or headers?
There was a problem hiding this comment.
For the AWS-IAM, since we didn't support the AWS V4 signature authentication mode, we needed a way to prompt the user for the region. This region is then used to generate the signature within the script. For QuickBooks, the realmId is required to build the proxy base_url. However, after discussing with Khaliq, we decided it was best not to alter the base_url as doing so might break compatibility for other users.
…-always-provided-in-the-authorization
hassan254-prog
deleted the
kelvinwari/ext-244-quickbooks-realmid-isnt-always-provided-in-the-authorization
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
realmIdin quickbooks.Issue ticket number and link
Checklist before requesting a review (skip if just adding/editing APIs & templates)