Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(integration): add support for sage intacct xml #3014

Conversation

hassan254-prog
Copy link
Contributor

Describe your changes

  • Add support for sage intacct xml

Issue ticket number and link

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • I added observability, otherwise the reason is:
  • I added analytics, otherwise the reason is:

Copy link

linear bot commented Nov 19, 2024

@hassan254-prog
Copy link
Contributor Author

Thanks to @TBonnin, @bodinsamuel and @khaliqgant , we can now comfortably add in support for such, no matter how complex the input body is without needing to add in a new authmode 😄

@hassan254-prog
Copy link
Contributor Author

@bodinsamuel, I would appreciate some clarification on how you intend to implement the TWO_STEP authentication in connect-ui, whether we should add credentials for this in providers.yaml. This will help me add the necessary validation for the dynamic credential fields, ensuring that the validation tests pass above.

@hassan254-prog hassan254-prog requested a review from a team November 19, 2024 08:45
@hassan254-prog hassan254-prog self-assigned this Nov 19, 2024
@TBonnin
Copy link
Collaborator

TBonnin commented Nov 19, 2024

#3014 (comment)

@hassan254-prog
Copy link
Contributor Author

@bodinsamuel , I have made some small addition with the latest commit, to now include credentials to TWO_STEP, auth mode, that way we wont have to painfully back fill them later.

@bodinsamuel
Copy link
Collaborator

that way we wont have to painfully back fill them later.

Nobody reads the logs, if you want it to be enforced you can add error = true

@hassan254-prog
Copy link
Contributor Author

that way we wont have to painfully back fill them later.

Nobody reads the logs, if you want it to be enforced you can add error = true

Thank you Samuel 🙏.

@hassan254-prog hassan254-prog enabled auto-merge (squash) November 20, 2024 09:19
@hassan254-prog hassan254-prog merged commit dff47ae into master Nov 20, 2024
20 checks passed
@hassan254-prog hassan254-prog deleted the kelvinwari/ext-231-add-support-for-sage-intacct-xml-webservices-api branch November 20, 2024 09:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants