feat(server): Add sync errors to connection count #3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
approved these changes
Nov 20, 2024
TBonnin
reviewed
Nov 20, 2024
| }); | ||
|
|
||
| const countResult = await connectionService.count({ environmentId: env.id }); | ||
| expect(countResult.isOk()).toBeTruthy(); |
There was a problem hiding this comment.
you don't really need this one because if it is an error the unwrap below will throw
nalanj
deleted the
alan/nan-2168-surface-integrationsconnections-errors-in-nango-ui/sync-errors-count
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds sync errors to response from connection count so we can show it in the UI
Issue ticket number and link
https://linear.app/nango/issue/NAN-2168/surface-integrationsconnections-errors-in-nango-ui
Checklist before requesting a review (skip if just adding/editing APIs & templates)