fix(jobs): execute close only once #3036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
commented
Nov 21, 2024
| } | ||
| return result; |
There was a problem hiding this comment.
once now handles any sort of return type for fn and memoize the result
nalanj
approved these changes
Nov 21, 2024
bodinsamuel
approved these changes
Nov 22, 2024
TBonnin
force-pushed
the
tbonnin/jobs-close-once
branch
from
0a7f09a to
0c4be5f
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice while investigating today's mini incident that the
closefunction could be executed multiple times if several unhandledRejections which create some sort of infinite loopIt is not fixing the root cause of the incident, still investigating