-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: improve on-events script logs #3049
Conversation
@@ -13,7 +13,7 @@ export interface FormatMessageData { | |||
environment?: { id: number; name: string } | undefined; | |||
connection?: { id: number; name: string } | undefined; | |||
integration?: { id: number; name: string; provider: string } | undefined; | |||
syncConfig?: { id: number; name: string } | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syncConfig
is already misnamed since it also applies to action
. A better name could be simply script
.
I attempted to rename it but it has a lot of implications including modifying ES models so I gave up cc @bodinsamuel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was referencing the table which worked with action but indeed does not scale anymore. We can create a new field yes 👍🏻
@@ -13,7 +13,7 @@ export interface FormatMessageData { | |||
environment?: { id: number; name: string } | undefined; | |||
connection?: { id: number; name: string } | undefined; | |||
integration?: { id: number; name: string; provider: string } | undefined; | |||
syncConfig?: { id: number; name: string } | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was referencing the table which worked with action but indeed does not scale anymore. We can create a new field yes 👍🏻
packages/types/lib/logs/messages.ts
Outdated
|
||
export interface OperationOnEvents { | ||
type: 'events'; | ||
action: 'run'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not put the actual event name here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at first I though that we wouldn't need to update the Operation when adding new event types but yes we could differentiate based on the event type. fixed in 7fe5d86
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7fe5d86
to
ca96f79
Compare
@nalanj Are you sure you have checkout/built correctly because it should show as |
@TBonnin Yeah, something weird was going on there. Got EVENT after another runthrough. |
Type = Events
https://linear.app/nango/issue/NAN-2219/on-events-script-follow-up
How to tests:
on-events
scripts in your nango.yamlnango generate
and modify the scriptsnango deploy dev