fix(runner): Remove setInterval from providers reload #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalanj
changed the title
TBonnin
approved these changes
Nov 25, 2024
bodinsamuel
approved these changes
Nov 25, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setIntervalcan cause problems because it doesn't ensure that multiple callbacks don't run at the same time. This removessetIntervalfrom provider reloading.Note: I'm not sure if it's worth it in this case to deploy runners or just wait until we deploy them next time.
See https://linear.app/nango/issue/NAN-2245/fix-do-not-use-setinterval
How I tested it: