Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(cli): Allow init to create any directory name #3338

Merged
merged 22 commits into from
Jan 30, 2025
Merged

feat(cli): Allow init to create any directory name #3338

merged 22 commits into from
Jan 30, 2025

Conversation

nalanj
Copy link
Contributor

@nalanj nalanj commented Jan 21, 2025

  • Allows any directory name. If no directory is given, init creates against the current directory, like git does.
  • Uses .nango directory as a sentinel for determining if it's a nango integration folder or not
  • Moves init into services directory for consistency
  • Moves several of the files that were created in init with template strings to be files in templates, also for consistency
  • Moves some tests around to be beside the init service
  • Updates some docs

@nalanj nalanj self-assigned this Jan 21, 2025
@nalanj nalanj requested a review from khaliqgant January 21, 2025 10:29
@nalanj
Copy link
Contributor Author

nalanj commented Jan 21, 2025

@khaliqgant here's what I have so far on allowing init with any directory

@nalanj nalanj marked this pull request as ready for review January 23, 2025 00:18
@nalanj nalanj requested a review from a team January 23, 2025 00:18
@nalanj nalanj marked this pull request as draft January 23, 2025 00:19
@nalanj nalanj removed the request for review from a team January 23, 2025 00:19
@nalanj nalanj marked this pull request as ready for review January 23, 2025 00:51
@nalanj nalanj requested a review from a team January 23, 2025 00:51
Copy link
Collaborator

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's gooo

@nalanj nalanj requested review from khaliqgant and removed request for khaliqgant January 28, 2025 19:00
@nalanj nalanj merged commit 81d059e into master Jan 30, 2025
17 checks passed
@nalanj nalanj deleted the alan/init branch January 30, 2025 15:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants