feat(persist): Deep merge records in batchUpdate #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
reviewed
Jan 29, 2025
nalanj
commented
Jan 29, 2025
| @@ -59,7 +59,7 @@ describe('Supervisor', () => { | |||
| void supervisor2.start(); | |||
|
|
|||
| await vi.waitUntil(() => tickSpy1.mock.calls.length > 0, { | |||
| timeout: 5000 | |||
| timeout: 10000 | |||
There was a problem hiding this comment.
Had this one fail on me in dev again, so I went ahead and bumped it up a good bit more.
bodinsamuel
reviewed
Jan 30, 2025
TBonnin
approved these changes
Jan 30, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
batchUpdateonly shallow merges. This switches it to deep merge, as request by some customers.I want to get @bastienbeurier's take on docs strategy here, but code is ready for review.
See https://linear.app/nango/issue/NAN-1982/partial-records-update
How I tested it
batchUpdatein a subsequent run to merge them.