Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(server): Separate auth related webhooks into their own log context #3427

Merged
merged 14 commits into from
Feb 7, 2025

Conversation

nalanj
Copy link
Contributor

@nalanj nalanj commented Jan 31, 2025

Isolates webhook logs for auth token refresh failure and connection creation and gives those webhook logs new types

See https://linear.app/nango/issue/NAN-1547/log-nango-webhooks

How I tested it:

  • Make sure webhooks are configured and enabled locally
  • Break an integration and trigger a token refresh to see a failed refresh webhook
  • Create a new connection to see a new connection

@nalanj nalanj self-assigned this Jan 31, 2025
@nalanj nalanj marked this pull request as ready for review February 6, 2025 19:48
@nalanj nalanj requested a review from a team February 6, 2025 19:48
Copy link
Collaborator

@TBonnin TBonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a lot of data passthrough just to create a log context 🙊

@nalanj
Copy link
Contributor Author

nalanj commented Feb 6, 2025

@TBonnin This made me very sad as I did it.

Copy link
Collaborator

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@nalanj nalanj merged commit b35d738 into master Feb 7, 2025
17 checks passed
@nalanj nalanj deleted the alan/auth-webhook-separate branch February 7, 2025 15:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants