fix(shared): Keep agents from cloning in simple-oauth2 #3447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
approved these changes
Feb 5, 2025
| const httpConfig = { headers, agents: {} }; | ||
| Object.defineProperty(httpConfig.agents, 'http', { get: () => httpAgent, enumerable: true }); | ||
| Object.defineProperty(httpConfig.agents, 'https', { get: () => httpsAgent, enumerable: true }); | ||
| Object.defineProperty(httpConfig.agents, 'httpsAllowUnauthorized', { get: () => httpsAgent, enumerable: true }); |
There was a problem hiding this comment.
I think we can simplify and avoid having to use defineProperty like this:
const getAgentConfig = (): { agents: AgentConfig } => ({
agents: {
get http() { return httpAgent; },
get https() { return httpsAgent; },
get httpsAllowUnauthorized() { return httpsAgent; }
}
});
const clientConfig: Merge<ModuleOptions, { http: WreckHttpOptions }> = {
...,
http: {
headers,
...getAgentConfig()
}
};
And adding a comment to mention the getter dynamic lookup trick used here. I am sure next week I am gonna have forgotten about it already
There was a problem hiding this comment.
I had already hit merge but I'll put a follow-up in real quick and merge it if this works out for that hot spot in the profiles, otherwise we'll just revert.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relating to request blocking we were seeing in profiles.
How I tested it
node_modules/simple-oauth2/lib/client/client.jsto print the copied config and make sure it included the resulting getter.