fix(types): SyncConfig -> DBSyncConfig #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodinsamuel
commented
Feb 5, 2025
| @@ -37,6 +40,6 @@ export interface IntegrationWithCreds extends Integration { | |||
| export interface Integration { | |||
| unique_key: string; | |||
| provider: string; | |||
| syncs: SyncConfig[]; | |||
| syncs: (Pick<DBSyncConfig, 'created_at' | 'updated_at'> & { name: string; description: string | null })[]; | |||
| actions: Action[]; | |||
| } | |||
There was a problem hiding this comment.
This type was completely wrong
bodinsamuel
commented
Feb 5, 2025
| deleted: false, | ||
| active: true, | ||
| type: 'sync' | ||
| }); |
There was a problem hiding this comment.
The type was very wrong, thankfully it was only used once
TBonnin
approved these changes
Feb 5, 2025
| @@ -4,4 +4,4 @@ export interface SyncResult { | |||
| deleted: number; | |||
| } | |||
|
|
|||
| export type SyncType = 'INCREMENTAL' | 'FULL' | 'WEBHOOK'; | |||
| export type SyncOperationType = 'INCREMENTAL' | 'FULL' | 'WEBHOOK'; | |||
There was a problem hiding this comment.
Nice to rename this one to something that is not sync type.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes https://linear.app/nango/issue/NAN-2547/fix-old-casing-of-sync-type
Initially wanted to only fix the SyncType casing but it was a good time to fix the entire type