fix(api): get records filter should accept uppercase and combined #3460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodinsamuel
commented
Feb 5, 2025
| @@ -38,6 +38,7 @@ export type ReturnedRecord = { | |||
| } & Record<string, RecordValue> & { id: string }; | |||
|
|
|||
| export type LastAction = 'ADDED' | 'UPDATED' | 'DELETED' | 'added' | 'updated' | 'deleted'; | |||
| export type CombinedFilterAction = `${LastAction},${LastAction}`; | |||
There was a problem hiding this comment.
Those are duplicated type, not sure why we are not using @types pkg here
There was a problem hiding this comment.
maybe @types didn't exist back then?
There was a problem hiding this comment.
ah maybe, I will make a following PR to sync
TBonnin
approved these changes
Feb 5, 2025
| @@ -38,6 +38,7 @@ export type ReturnedRecord = { | |||
| } & Record<string, RecordValue> & { id: string }; | |||
|
|
|||
| export type LastAction = 'ADDED' | 'UPDATED' | 'DELETED' | 'added' | 'updated' | 'deleted'; | |||
| export type CombinedFilterAction = `${LastAction},${LastAction}`; | |||
There was a problem hiding this comment.
maybe @types didn't exist back then?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
GET /recordsfilter param should accept uppercase and combinedI missed that when checking the openapi spec, it's not documented there but it's in the node-client. e.g:
ADDED,updated