feat: runner use new image #3468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalanj
approved these changes
Feb 6, 2025
TBonnin
approved these changes
Feb 6, 2025
packages/jobs/lib/runner/render.ts
Outdated
| plan: getPlan(node), | ||
| ...(node.image.includes('-runner') | ||
| ? {} | ||
| : { envSpecificDetails: { dockerCommand: 'node packages/runner/dist/app.js 80 dockerized-runner' } }) | ||
| }, | ||
| envVars: [ | ||
| { key: 'PORT', value: '80' }, |
There was a problem hiding this comment.
you could have a port variable and use it here and in the dockerCommand so they are always in sync
Yes I'm just keeping it until the next successful deploy just in case I need to revert |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Contributes to https://linear.app/nango/issue/NAN-605/use-image-for-runner
Runner: Use unified docker image
Tested in staging https://dashboard.render.com/pserv/srv-cui9s49u0jms739cd95g/settings
It's less transparent since we need to specify a docker command, happy to get suggestion here. I expect that after the migration, we can set it as the default
Fix deprecated runtime configuration
see doc https://api-docs.render.com/reference/create-service
Remove docker login leftovers