fix(jobs): logs track_deletes results #3493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodinsamuel
commented
Feb 10, 2025
| ...existingResult, | ||
| [model]: { | ||
| added: Number(added) + Number(incomingResult?.added), | ||
| updated: Number(updated) + Number(incomingResult?.updated) | ||
| updated: Number(updated) + Number(incomingResult?.updated), | ||
| deleted: deletedValue + incomingDeletedValue |
There was a problem hiding this comment.
Not sure why it was done conditionally, maybe it's wrong, let me know
There was a problem hiding this comment.
Think this was from legacy as we didn't want to show deletes at all since that wasn't a thing in the initial implementation.
There was a problem hiding this comment.
is it also what we send back in the webhook? Can customers have logic not expecting deleted attributes?
There was a problem hiding this comment.
We always send at least deleted: 0 in the webhook by default (see: webhooks/lib/sync.ts:101)
So I don't think it's an issue here
khaliqgant
approved these changes
Feb 10, 2025
nalanj
approved these changes
Feb 10, 2025
TBonnin
approved these changes
Feb 10, 2025
| ...existingResult, | ||
| [model]: { | ||
| added: Number(added) + Number(incomingResult?.added), | ||
| updated: Number(updated) + Number(incomingResult?.updated) | ||
| updated: Number(updated) + Number(incomingResult?.updated), | ||
| deleted: deletedValue + incomingDeletedValue |
There was a problem hiding this comment.
is it also what we send back in the webhook? Can customers have logic not expecting deleted attributes?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes