Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(persist): Filter external ids to remove 0x00 #3498

Merged
merged 5 commits into from
Feb 11, 2025
Merged

fix(persist): Filter external ids to remove 0x00 #3498

merged 5 commits into from
Feb 11, 2025

Conversation

nalanj
Copy link
Contributor

@nalanj nalanj commented Feb 10, 2025

Persist was having issues where if an external id included 0x00 inserts would fail. This fixes that.

  • for getRecords there's a new test
  • for upsert and updating in persist I set up a sync that had 0x00 in its id because the code path where the external id is extracted currently isn't tested

@nalanj nalanj self-assigned this Feb 10, 2025
@nalanj nalanj marked this pull request as ready for review February 10, 2025 21:17
@nalanj nalanj requested review from a team and khaliqgant February 10, 2025 21:17
@nalanj nalanj enabled auto-merge (squash) February 11, 2025 13:58
@nalanj nalanj merged commit b946e47 into master Feb 11, 2025
16 checks passed
@nalanj nalanj deleted the alan/null-external-id-char branch February 11, 2025 14:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@TBonnin TBonnin TBonnin approved these changes

@khaliqgant khaliqgant Awaiting requested review from khaliqgant

Assignees

@nalanj nalanj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalanj @TBonnin