Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(logs): unify HTTP logs and retry #3503

Merged
merged 3 commits into from
Feb 11, 2025
Merged

fix(logs): unify HTTP logs and retry #3503

merged 3 commits into from
Feb 11, 2025

Conversation

bodinsamuel
Copy link
Collaborator

@bodinsamuel bodinsamuel commented Feb 11, 2025 •
edited
Loading

Changes

Fixes https://linear.app/nango/issue/NAN-2682/unify-http-logs

  • Unify HTTP logs and retry

    • Messages were inconsistent
    • Retry messages were displayed before the failed HTTP call
    • type: http was used for non-http logs
    • Proxy was not logging retries

  • Fix could not use warn and logToConsole

  • Fix typo in openapi spec

🧪 Tests

  • Run the dashboard
  • Make some proxy calls
  • Run some syncs with proxy calls

Sync with successful proxy

Sync with failed proxy

Failed proxy with retries

Failed proxy no retries

Successful proxy

@bodinsamuel bodinsamuel self-assigned this Feb 11, 2025
@linear Linear
Copy link

linear bot commented Feb 11, 2025

NAN-2682 Unify HTTP logs

@bodinsamuel bodinsamuel requested a review from a team February 11, 2025 12:27
@bodinsamuel bodinsamuel merged commit 8b92740 into master Feb 11, 2025
16 checks passed
@bodinsamuel bodinsamuel deleted the sam/25_02_11/fix/http-log-unify branch February 11, 2025 16:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nalanj nalanj nalanj approved these changes

Assignees

@bodinsamuel bodinsamuel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bodinsamuel @nalanj