fix: authenticate memory warning logs from runner to persist #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
commented
Feb 11, 2025
| @@ -56,6 +56,7 @@ export const ENVS = z.object({ | |||
| IDLE_MAX_DURATION_MS: z.coerce.number().default(0), | |||
| RUNNER_NODE_ID: z.coerce.number().optional(), | |||
| RUNNER_URL: z.string().url().optional(), | |||
| RUNNER_MEMORY_WARNING_THRESHOLD: z.coerce.number().optional().default(85), | |||
There was a problem hiding this comment.
increase the limit to 85 because I don't want to spam logs too much. We can tweak this value later
bodinsamuel
approved these changes
Feb 11, 2025
TBonnin
force-pushed
the
tbonnin/nan-2690/fix-memory-warning
branch
from
837c06d to
cea4037
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making sure the correct authorization header is passed when making a call from runner to log memory usage warnings.
It was much easier to fix than I thought I wish I had looked into it earlier.
To test it locally you are gonna need to modify/remove the condition
if (memoryUsagePercentage > MEMORY_WARNING_PERCENTAGE_THRESHOLD)