feat(ui): show sync variant on connections page #3588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodinsamuel
reviewed
Feb 27, 2025
| <div className="w-36 max-w-3xl truncate">{sync.name}</div> | ||
| <div className="w-36 max-w-3xl truncate"> | ||
| {sync.name} | ||
| {showSyncVariant && ' '} |
There was a problem hiding this comment.
You can remove that use flex wrapper
<div className="flex gap-2">{...}</div>
bodinsamuel
approved these changes
Feb 27, 2025
https://linear.app/nango/issue/NAN-2726/[design]-sync-variant-feature-quick-one Show sync variant in a grey bubble next to the sync name Only show variant bubble if there is more than the base variant Long variant name are truncated Full name can be seen in a tooltip
TBonnin
force-pushed
the
tbonnin/nan-2418/sync-variant-9
branch
from
90a7328 to
bdc011e
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/nango/issue/NAN-2726/[design]-sync-variant-feature-quick-one
Show sync variant in a grey bubble next to the sync name
Only show variant bubble if there is more than the base variant
Long variant names are truncated. Full name can be seen in a tooltip