Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add eig_vol argument to EigenModeSource class constructor #2767

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented Jan 23, 2024

Fixes #2755.

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.79%. Comparing base (9cc041e) to head (62ea453).
Report is 40 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2767   +/-   ##
=======================================
  Coverage   73.78%   73.79%           
=======================================
  Files          18       18           
  Lines        5421     5423    +2     
=======================================
+ Hits         4000     4002    +2     
  Misses       1421     1421           
Files with missing lines Coverage Δ
python/source.py 94.08% <100.00%> (+0.03%) ⬆️

@oskooi
Copy link
Collaborator Author

oskooi commented Jan 24, 2024

Note: I used this PR along with the one-line change in mpb.cpp in #2285 to verify the accuracy of the adjoint gradients for the EigenmodeCoefficient objective function using the 2d test involving a 1d binary grating described in #2054 (comment). After this PR and #2285 are merged, we may therefore add the 1d diffraction grating as a new unit test for the adjoint solver.

@stevengj
Copy link
Collaborator

LGTM.

@stevengj stevengj merged commit 46c7920 into NanoComp:master Jan 25, 2024
5 checks passed
@oskooi oskooi deleted the eigsrc_eigvol branch January 25, 2024 21:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
3 participants