Machine Add the possibility to force broker to always assign the same machine to a user #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dynamiccast
suggested changes
Oct 2, 2016
| @@ -29,6 +29,8 @@ to avoid commiting those changes | |||
| - machinesName (Defaults to 'Nanocloud Exec Server') default name for machines | |||
| - plazaURI (Defaults to https://s3-eu-west-1.amazonaws.com/nanocloud/plaza/1.0.0/windows/amd64/plaza.exe) URL to download plaza from | |||
| - plazaPort (Defaults to 9090) port to communicate with plaza | |||
| - neverTerminateMachine (Defaults to false) if set to true, machines are | |||
| never destroyed, users have always the same machine all times. | |||
There was a problem hiding this comment.
users have always the same machine all times. -> users always keep the same machine at all time.
| isActive: machine.isSessionActive(), | ||
| config: ConfigService.get('neverTerminateMachine') | ||
| }) | ||
| .then((props) => { |
There was a problem hiding this comment.
You should use object destructuring in this case: https://ponyfoo.com/articles/es6-destructuring-in-depth
corentindrouet
force-pushed
the
machine_assignement
branch
from
3f10646 to
08a4aff
Compare
dynamiccast
suggested changes
Oct 3, 2016
| config: ConfigService.get('neverTerminateMachine') | ||
| }) | ||
| .then((props) => { | ||
| var {isActive, config} = props; |
There was a problem hiding this comment.
{isActive, config} could and should be in the argument list.
corentindrouet
force-pushed
the
machine_assignement
branch
3 times, most recently
from
e5079c5 to
c798571
Compare
Stop will not destroy the machine, she will just stop taking resources. Start on a stopped machine will rerun her, so she can be reused.
with the right attribute (start, stop).
Stop will not destroy the machine, she will just stop taking resources. Start on a stopped machine will rerun her, so she can be reused.
to a user. This option is available only in the config file.
So we let the startMachine function do it.
corentindrouet
force-pushed
the
machine_assignement
branch
from
c798571 to
698d0dd
Compare
dynamiccast
approved these changes
Oct 4, 2016
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configuration variable to set this option.
If set to true, no machines are terminated. If a machine expire, it is just stopped, and started again when the user want to use it.
Fixes #294