Change awsImage and qemuMemory defaults values #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dynamiccast
suggested changes
Oct 3, 2016
| @@ -82,7 +82,7 @@ MACHINES=[{"name": "My Machine", "type": "manual", "ip": "1.2.3.4", "username": | |||
| - awsSecretAccessKey AWS private key | |||
| - awsKeyName private key name | |||
| - awsPrivateKey (Defaults to /opt/back/id_rsa) path to where the key will be stored | |||
| - awsImage (Defaults to ami-09e61366) Nanocloud's execution servers default image) | |||
| - awsImage (Defaults to empty string) Nanocloud's execution servers default image | |||
There was a problem hiding this comment.
There is no default value if the default value is expected to be set by the administrator.
dynamiccast
approved these changes
Oct 3, 2016
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AwsImage:
ami-09e61366--> Empty string (Fixes #217)qemuMemory:
4096-->2048Change the README file accordingly.