-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
update face list #725
update face list #725
Conversation
Here's the translation to Chinese: 审阅者指南 by Sourcery该拉取请求更新了人脸列表配置文件。 由于更改看起来简单,且不需要可视化表示,因此未生成任何图表。 文件级更改
提示和命令与 Sourcery 交互
自定义您的体验访问您的仪表板以:
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThe pull request updates the face list configuration file. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘿 @clansty - 我已经审查了你的更改 - 以下是一些反馈:
整体评论:
- 请提供对 face_config.json 的实际更改,并附上解释正在更新什么以及为什么需要这些更改的描述。当前的 PR 缺乏足够的审查信息。
以下是我在审查期间查看的内容
- 🟢 一般性问题:一切看起来都很好
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用反馈来改进你的评论。
Original comment in English
Hey @clansty - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide the actual changes being made to face_config.json along with a description explaining what is being updated and why these changes are needed. The current PR lacks sufficient information for review.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Summary by Sourcery
Chores:
Original summary in English
Summary by Sourcery
Chores: