✨ classic: added definePrefab and registerPrefab #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately there are several formatting changes included as prettier took over a bunch of unformatted code.
The gist of the changes is the following:
definePrefab
returns aPrefabToken
, containing a list of components and aMap<World, eid>
registerPrefab
assigns an eid to the prefab by internally callingaddPrefab
, and pairs the eid with the world in thePrefabToken
world -> eid mapIsA
(or any other relation) on aPrefabToken
stores it in the relation's$pairsMap
and the component's$pairTarget
, as it would for an eidgetRelationTargets
checks if$pairTarget
is aPrefabToken
and converts it to an eid, using the world -> eid map ofPrefabToken
I left the definition of the
Prefab
component in Entity.ts, as moving it out of there would cause circular dependency issues. I suggest a separate refactor to prevent such issues.See the included integration test (
Prefab.test.ts
) for usage.