Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

⏃⌰⍙⏃⊬⌇ ⏁⍀⎍⌇⏁ ⏃⌰⟟⟒⋏ ⏁⟒☊⊑⋏⍜⌰⍜☌⊬ #7531

Closed

Conversation

cristiancmoises
Copy link

[Update FlatDebuggerRmiAPI.java]
Documentation: Improved method comments to clarify purpose and parameters.
Variable Naming: Used more descriptive names where appropriate to enhance code readability.
Code Structure: Organized the methods for better logical flow, grouping related functionalities together.
Lambda Simplification: Used method references and lambda expressions to streamline code where applicable.
General Cleanliness: Ensured consistent formatting and indentation for better visual clarity.

[Update JsonDoclet.java]
Code Readability: Improved readability by using consistent formatting and indentation.
Streamlined Logic: Used Java's enhanced switch statements and lambda expressions for more concise code.
Exception Handling: Enhanced error logging when writing to files to provide clearer feedback.
Method Extraction: Extracted repetitive logic into dedicated private methods for clarity and reuse.
Immutable Collections: Used Set.of and List.of to create immutable collections for options, improving safety and readability.
Descriptive Method Names: Enhanced method names to clarify their purpose.

Documentation: Improved method comments to clarify purpose and parameters.
Variable Naming: Used more descriptive names where appropriate to enhance code readability.
Code Structure: Organized the methods for better logical flow, grouping related functionalities together.
Lambda Simplification: Used method references and lambda expressions to streamline code where applicable.
General Cleanliness: Ensured consistent formatting and indentation for better visual clarity.
Code Readability: Improved readability by using consistent formatting and indentation.
Streamlined Logic: Used Java's enhanced switch statements and lambda expressions for more concise code.
Exception Handling: Enhanced error logging when writing to files to provide clearer feedback.
Method Extraction: Extracted repetitive logic into dedicated private methods for clarity and reuse.
Immutable Collections: Used Set.of and List.of to create immutable collections for options, improving safety and readability.
Descriptive Method Names: Enhanced method names to clarify their purpose.
@ryanmkurtz
Copy link
Collaborator

What does the title of this PR mean?

@ryanmkurtz
Copy link
Collaborator

Thank you for the submission, but we generally do not encourage or accept this type of "style" PR. Please see https://github.com/NationalSecurityAgency/ghidra/blob/master/CONTRIBUTING.md#patch-submission-tips for more info.

@ryanmkurtz ryanmkurtz closed this Feb 21, 2025
@ryanmkurtz ryanmkurtz added the Reason: Won't support This will not be supported by the Ghidra team. label Feb 21, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Reason: Won't support This will not be supported by the Ghidra team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants